Implement the export process - Githubissues

common-voice / sentence-collector

Tool to collect and review sentences for Common Voice

https://commonvoice.mozilla.org/sentence-collector/

Mozilla Public License 2.0

81 stars 64 forks source link

Implement the export process #27

Closed nukeador closed 5 years ago

nukeador commented 5 years ago

We need to document how the export process of the validated sentences works.

nukeador commented 5 years ago

The exported sentences should land in their locale folder in this repo as txt files:

https://github.com/mozilla/voice-web/tree/master/server/data/

MichaelKohler commented 5 years ago

This depends on #4 as we only want approved strings to be exported.

MichaelKohler commented 5 years ago

As discussed with Nuke, we're gonna export all the approved strings into sentence-collector.txt to make our life easier (not tracking chunks)

nukeador commented 5 years ago

@MichaelKohler but note we'll need one file per locale.

MichaelKohler commented 5 years ago

of course :)

MichaelKohler commented 5 years ago

So currently I see the following tasks:

Export approved sentences
Integrate the possibility to do cleanups (at the beginning used for sorting the sentences to create better diffs)
(?) Check for duplicate sentences already in the voice-web repo and not export them
Create yarn run task to have a "one command" process
Manually creating voice-web commits/PRs with the export for now
Document all of this

nukeador commented 5 years ago

Let's aim to have a functional export fist and document how, the rest are nice to haves for this release.

MichaelKohler commented 5 years ago

PR: https://github.com/Common-Voice/sentence-collector/pull/133

export: https://github.com/mozilla/voice-web/compare/master...MichaelKohler:sc_export_test?expand=1

MichaelKohler commented 5 years ago

:tada: This issue has been resolved in version 1.3.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: