common-voice / sentence-collector

Tool to collect and review sentences for Common Voice
https://commonvoice.mozilla.org/sentence-collector/
Mozilla Public License 2.0
81 stars 63 forks source link

[th] Adjust minimum chars for a sentence #442

Closed bact closed 3 years ago

bact commented 3 years ago
MichaelKohler commented 3 years ago

As said in Matrix, reflecting here as well: https://matrix.to/#/!WpvTgzNfcLIgzJZdSE:mozilla.org/$Ihtxvr7o0nTdSBKnlFr8k1OJawBWK14PVjJC7z1CKsg?via=mozilla.org&via=matrix.org&via=tchncs.de

Looks like the minimum recording duration is 1500ms, last changed here: https://github.com/common-voice/common-voice/commit/f00f8f423ca1c03bae2a8931f492cb45584f64dd#diff-b0fc0339b967e566feaf9f768dfcc72a5f9fe47fc345a315f590088726033a35R49 with 500ms for the benchmark sentences. I would suggest that we figure out first if that generally could be decreased before only allowing longer sentences. Maybe jz (phire) remembers why it's set at that value.

bact commented 3 years ago

Thanks Michael. We will discuss among Thai contributors on which minimum length of chars will work.

bact commented 3 years ago

Note, current MIN_RECORDING_MS is now 1000 (1 sec). https://github.com/common-voice/common-voice/blob/1d6a861a234e5cd8cd075031b95095ba0ed9428b/web/src/components/pages/contribution/speak/speak.tsx#L50

bact commented 3 years ago

As the new minimum time is 1 sec and looks like we longer have a recording problem with that. I will close this issue - for now.