Enabling uppercase for key based validation

common-voice / sentence-collector

Tool to collect and review sentences for Common Voice

https://commonvoice.mozilla.org/sentence-collector/

Mozilla Public License 2.0

81 stars 62 forks source link

Enabling uppercase for key based validation #487

Closed HarikalarKutusu closed 3 years ago

HarikalarKutusu commented 3 years ago

I think it is in web/src/components/review-form.tsx... It only handles lowercase letters. I hit this while reviewing with caps-lock on. Maybe it is a good idea to lowercase it before checks...

MichaelKohler commented 3 years ago

Indeed, the code block in https://github.com/common-voice/sentence-collector/blob/main/web/src/components/review-form.tsx#L111-L123 should first convert it to lowercase and then do these checks. Nice find!

MichaelKohler commented 3 years ago

Expected behavior

Have some sentences in the review queue
Turn on CAPS LOCK
Press the short cut keys (y/n/s) and the sentence should be marked accordingly

MichaelKohler commented 3 years ago

:tada: This issue has been resolved in version 2.12.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: