search

common-voice / sentence-collector

Tool to collect and review sentences for Common Voice
https://commonvoice.mozilla.org/sentence-collector/
Mozilla Public License 2.0
81 stars 63 forks source link

Localization: Support RTL #493

Closed MichaelKohler closed 2 years ago

MichaelKohler commented 2 years ago

We need to support right-to-left languages. I'm sure there would be some issues with the design, needs to be looked at closer.

MichaelKohler commented 2 years ago

https://github.com/common-voice/sentence-collector/commit/1937f997ca0d25f7ccaf858aa2da4d94b35c32eb#diff-dc7a56326bb0ee5bffa938ee9ccbac84d2fbd69a0bd618a8a929d6293d4f28efR13 introduced basic RTL support. I quickly verified this, and I didn't notice anything that is obviously wrong. I'm sure there are gonna be a few design adjustments needed, but let's tackle those when they come up.