common-voice / sentence-collector

Tool to collect and review sentences for Common Voice
https://commonvoice.mozilla.org/sentence-collector/
Mozilla Public License 2.0
81 stars 62 forks source link

Localization: Handle validation error messages #494

Closed MichaelKohler closed 2 years ago

MichaelKohler commented 3 years ago

Currently the exact validation error messages are coming from the backend. These should be localized too. We need to figure out a reasonable way to do this.

MichaelKohler commented 2 years ago

After thinking about this, I don't think translating the validation error messages into all languages makes sense. Some of these are very language specific.

On the other hand, we are using the EN validation file as a fallback, so we'd expose English strings for those. Needs more exploration.

MichaelKohler commented 2 years ago

After exploring this for a bit, I think the approach here could be the following:

While this is not perfect, I feel this is a reasonable way forward without having to implement the full localization infra on the backend.

MichaelKohler commented 2 years ago

:tada: This issue has been resolved in version 2.13.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: