search

common-voice / sentence-collector

Tool to collect and review sentences for Common Voice
https://commonvoice.mozilla.org/sentence-collector/
Mozilla Public License 2.0
81 stars 62 forks source link

Localization: Correctly apply localization in tests #496

Closed MichaelKohler closed 3 years ago

MichaelKohler commented 3 years ago

With #490 tests do not correctly render the localized strings by mocking it away in the jest setup.ts file. We should fix that so the assertions are run on the localized components, and not on the placeholder texts.

MichaelKohler commented 3 years ago

Note that https://github.com/common-voice/sentence-collector/pull/509 introduced one more mock and now checks for mocked strings. This needs to be reverted as well.

MichaelKohler commented 3 years ago

:tada: This issue has been resolved in version 2.12.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: