search

common-voice / sentence-collector

Tool to collect and review sentences for Common Voice
https://commonvoice.mozilla.org/sentence-collector/
Mozilla Public License 2.0
81 stars 62 forks source link

Localization: Remove placeholder strings #518

Closed MichaelKohler closed 3 years ago

MichaelKohler commented 3 years ago

At this point the fallback language mechanism for localization should work well enough so that we can remove all the placeholder strings in the components.

Example:

<Localized id="sc-settings-failed">
  <p className="form-error">Could not change settings. Please try again.</p>
</Localized>

should become

<Localized id="sc-settings-failed">
  <p className="form-error"></p>
</Localized>
HarikalarKutusu commented 3 years ago

I can handle these if you want so that you can focus on Pontoon integration etc.

MichaelKohler commented 3 years ago

That's up to you, feel free to work on this if you want to :)

HarikalarKutusu commented 3 years ago

OK, I'll handle that tomorrow... The campaign is doing not bad anyway.

MichaelKohler commented 3 years ago

:tada: This issue has been resolved in version 2.12.2 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: