search

common-voice / sentence-collector

Tool to collect and review sentences for Common Voice
https://commonvoice.mozilla.org/sentence-collector/
Mozilla Public License 2.0
81 stars 62 forks source link

Jump in review page after button press #571

Closed robovoice1 closed 1 year ago

robovoice1 commented 2 years ago

I started a review process in sentence collector, english language. I positioned the screen to my needs (see pic1).

Screenshot_20211213-070559

After reviewing (100+) sentences within the review process the page "jumps down" (see pic2). Screenshot_20211213-071327

The buttons (reject,.skip, approve) are not reachable anymore, and the contributor must move the page up again. (possible accidental left/right swipes within the text box included)

A fixed position when in review process or place the text box as high as possible to the top of the review page could improve this for smartphone reviewers for reviewing many sentences. Place the explaining text under the box???

Os: Android10 Browser: Fx mobile 95.1.0 (Build #2015848803) AC: 95.0.13, 58539f17f6 GV: 95.0-20211129150630 AS: 86.0.1 Hardware: Fairphone 3 plus used

MichaelKohler commented 2 years ago

I started to look into this. This seems to happen when a review is submitted. I would argue that this per se is not a bug, as it's good that the user sees that happening.

However, as in your case most likely, there were more sentences added during your review session, and then got loaded, so it seemed like a bug. I'm keeping this open if anyone has a better idea on how to improve UX here (I don't think we should move the explanation below the whole card/buttons, we need to find another fix for this).

robovoice1 commented 2 years ago

OK, it was just a quick proposal with the text.

robovoice1 commented 2 years ago

Please watch screenrecording. I contributed/added today about 100 german sentences, after approving 2 sentences in review process the page jumps down. (No down swiping from the contributor after tapping on the approve button!)

https://user-images.githubusercontent.com/92784377/147850423-d6e6b80a-da71-45fe-85dc-17df70294d63.mp4

MichaelKohler commented 2 years ago

So far I wasn't able to reproduce this. I will keep having a look though.

robovoice1 commented 2 years ago

With Pixel 4a phone and Android 12/grapheneOS no jumping down at all!

MichaelKohler commented 2 years ago

Is that because the screen resolution is higher and therefore the content fits anyway?

robovoice1 commented 2 years ago

Good point. Fairphone 3 itself is bigger, but pixel 4a has bigger screen resolution (more is displayed!)

MichaelKohler commented 2 years ago

I would love some help here if somebody can figure out what exactly is going wrong here :)

robovoice1 commented 2 years ago

Maybe with this: https://developer.mozilla.org/en-US/docs/Tools/Responsive_Design_Mode

MichaelKohler commented 2 years ago

My comment was meant for figuring out what in the code actually creates this issue. But yes, that indeed is the way to go to reproduce this.

MichaelKohler commented 1 year ago

Thanks for bringing this up. The Sentence Collector now has moved to https://commonvoice.mozilla.org/write and therefore is now hosted in the main Common Voice repository. That being said, this issue is no longer relevant as that part of the review process has been changed.