search

common-voice / sentence-collector

Tool to collect and review sentences for Common Voice
https://commonvoice.mozilla.org/sentence-collector/
Mozilla Public License 2.0
81 stars 63 forks source link

Replace "submit" button in "add sentences" section (smartphone) #574

Closed robovoice1 closed 2 years ago

robovoice1 commented 2 years ago

Please compare picture 1 and 2 pic1 is from review section (as expected) Screenshot_20211213-221057

pic2 is from the "add sententences" section - swiped completely to the bottom. Screenshot_20211213-221124

a) "submit" button should be in the middle b) button is divided by a line c) more space between "submit" and "discourse" when replaced in the middle of the page. Contributers with bigger fingers have a problem, otherwise.

Os: Android10 Browser: Fx mobile stable 95.1.0 (Build #2015848803) AC: 95.0.13, 58539f17f6 GV: 95.0-20211129150630 AS: 86.0.1 Hardware: Fairphone 3 plus

MichaelKohler commented 2 years ago

Thanks for filing this.

The Review page is generally centered, this page is not. So I don't necessarily agree that it should be centered. For the spacing, same root cause as #572 so I'm gonna mark this as duplicate.

robovoice1 commented 2 years ago

ok