common-voice / sentence-collector

Tool to collect and review sentences for Common Voice
https://commonvoice.mozilla.org/sentence-collector/
Mozilla Public License 2.0
81 stars 63 forks source link

Review before submission of too long sentences results in unresponsive buttons #585

Closed robovoice1 closed 2 years ago

robovoice1 commented 2 years ago

Here is what i tried: Copy and paste the cv faq from the cv website and add those very long sentencs (first recording edited sentences, but not every critera was fulfilled for sc) into sentence collector. Second try and recording unedited sentences ( copy and paste as is) Result by doing so is: Unresponsive buttons (reject/skip/approve), the too long sentences overlaying the buttons, the first sentence stays visible and swiping for reject (left) the sentences behind the first get rejected (first recording) Unresponsive confirm button. see pic.

Screenshot_20220119-133807 Screenshot_20220119-135414 Screenshot_20220119-140103

Pixel 4 a Android 12/GrapheneOs Fx mobile nightly android Latest release

robovoice1 commented 2 years ago

https://user-images.githubusercontent.com/92784377/150141829-ca6eace2-1d1d-4b1e-a466-3104af0b496d.mp4

robovoice1 commented 2 years ago

https://user-images.githubusercontent.com/92784377/150142483-06aa48bc-ae27-428c-a2ba-6528b4b21119.mp4

robovoice1 commented 2 years ago

Ps: Everything was rejected from my side and leftovers deleted from this "submission".

robovoice1 commented 2 years ago

https://user-images.githubusercontent.com/92784377/150157131-f811045c-70e4-4e49-90ed-480be2e3bde2.mp4

Recording from Fairphone 3+, Android 10, Fx mobile nightly latest release

MichaelKohler commented 2 years ago

Thanks for filing this. This is the review before the actual submission, right?

If so, the validations only happens once fully submitted. Therefore it will include all sentences, even those that are not fulfilling all criteria. That might be worth an improvement, but would need to be discussed further.

That being said, we should look again into not overflowing the cards. I thought I had added a fix for that, but might not be remembering correctly.

robovoice1 commented 2 years ago

Yes it is. But 1 sentence got in, which i deleted under my sentences. English sentence in german section, when trying this on Fairphone3.

MichaelKohler commented 2 years ago

:tada: This issue has been resolved in version 2.16.4 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: