search

common-voice / sentence-collector

Tool to collect and review sentences for Common Voice
https://commonvoice.mozilla.org/sentence-collector/
Mozilla Public License 2.0
81 stars 62 forks source link

Profile page: Improve two labels #88

Closed Txopi closed 5 years ago

Txopi commented 5 years ago

The main menu talks about "add" and "review", but the profile page talks about "submitted" and "validated" sentences. I think profile page should say something like this:

MichaelKohler commented 5 years ago

@nukeador I agree, do you?

nukeador commented 5 years ago

Yep

MichaelKohler commented 5 years ago

Here are the lines that need to be changed for this: https://github.com/Common-Voice/sentence-collector/blob/fde0444e876f00ef706a91c9cf9f9d36d00df7ca/web/src/components/pages/profile.jsx#L187

It's enough to replace the text directly, as we are not using any localization yet. For instructions on how to set up the environment locally to test this change, please refer to the README. I'm happy to help if somebody wants to tackle this and gets stuck along the way.

MichaelKohler commented 5 years ago

Additionally, when nothing has been done yet, we show the following sentence:

No sentences submitted or validated, try reviewing some sentences now?

This should read "No sentences submitted or reviewed, .."

amanriquez commented 5 years ago

Hi! I'm a beginning bootcamp student, really looking to get into open source and this looks like a first issue I could handle...I'd really like to help. Could I do this? could you give me a little more guidance?

MichaelKohler commented 5 years ago

Hi @amanriquez, great to hear that! Yes, this issue is currently not being worked on, so this would be a great candidate for you!

First of all, it would make sense to get the website running locally, so you can also test your fixes. The https://github.com/Common-Voice/sentence-collector/blob/master/README.md has some documentation on how to set up the local environment. There might be some parts missing or unclear, so don't hesitate to ask me any questions here :)

Once you have the setup running locally, we can move forward by fixing this here. https://github.com/Common-Voice/sentence-collector/issues/88#issuecomment-452675259 has some pointers, but also here, feel free to ask anything you need.

Happy to help if you run into any problems!

amanriquez commented 5 years ago

Awesome thank you very much! I will get on it by tomorrow and let you know if I get stuck.

amanriquez commented 5 years ago

Hey Michael, so I managed to set up the environment, updated node, got Kinto running, and everything seemed to go well until yarn, yarn start, I got quite a few errors, here attached in a .txt file. not sure which one to fix first, or how? Thank you for the opportunity and your time! yarn-start-issues.txt

MichaelKohler commented 5 years ago

gyp info spawn args '-Goutput_dir=.' ] No receipt for 'com.apple.pkg.CLTools_Executables' found at '/'. No receipt for 'com.apple.pkg.DeveloperToolsCLILeo' found at '/'. No receipt for 'com.apple.pkg.DeveloperToolsCLI' found at '/'. gyp: No Xcode or CLT version detected! gyp ERR! configure error

This looks like XCode/CLT is not installed. Have you installed a copy of XCode? If not, you'll need to do so, otherwise some dependencies can't be built. If you already have XCode, you probably also need to run xcode-select --install to install the XCode command line tools. Can you try to install XCode, install the command line tools and then run yarn again and see if everything installs correctly?

amanriquez commented 5 years ago

got it running!

amanriquez commented 5 years ago

Ok there it goes..let me know if I did this right!

MichaelKohler commented 5 years ago

:tada: This issue has been resolved in version 1.4.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: