search

common-workflow-lab / cwl-ts-auto

Autogenerated TypeScript bindings for CWL
Apache License 2.0
6 stars 4 forks source link

Fix default parameters for class properties not working #16

Closed ZimmerA closed 2 years ago

ZimmerA commented 2 years ago

This fixes the default values for class field parameters in constructors. The default values are currently ignored because the parameters have to be marked as optional in the property interface, which is used as a type in the constructor.

codecov-commenter commented 2 years ago

Codecov Report

Merging #16 (7d219c0) into main (644bab4) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #16   +/-   ##
=======================================
  Coverage   33.55%   33.55%           
=======================================
  Files         126      126           
  Lines        6372     6372           
  Branches     1569     1569           
=======================================
  Hits         2138     2138           
  Misses       3939     3939           
  Partials      295      295
Flag Coverage Δ
unittests 33.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/index.ts 100.00% <ø> (ø)
src/util/Internal.ts 100.00% <ø> (ø)
src/util/LoaderInstances.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 644bab4...7d219c0. Read the comment docs.