common-workflow-lab / galaxy

Fork of Galaxy (http://galaxyproject.org/) attempting to implement the CWL spec.
https://www.commonwl.org
Other
10 stars 2 forks source link

Enhance the Python typing for the files we touch #137

Closed mr-c closed 2 years ago

mr-c commented 3 years ago
  1. Find a Python file we touch in https://github.com/common-workflow-lab/galaxy/pull/47 https://github.com/galaxyproject/galaxy/pull/12909 or https://github.com/common-workflow-language/galaxy/pull/123
  2. Edit https://github.com/galaxyproject/galaxy/blob/dev/setup.cfg#L24 to remove the check_untyped_defs = False from underneath that filename
  3. tox -e mypy
  4. Fix/enhance types ; send PR to https://github.com/galaxyproject/galaxy/ against the dev branch
  5. Repeat from 1 with another file
mr-c commented 3 years ago

I've assigned myself, but others are welcome as well

dakariakin commented 3 years ago

Started work in https://github.com/dakariakin/galaxy/commits/added_types

dakariakin commented 3 years ago

Sent WIP PR https://github.com/galaxyproject/galaxy/pull/12884 Will continue with

mr-c commented 2 years ago

Tomorrow I plan on working on

dakariakin commented 2 years ago

Fixed in https://github.com/galaxyproject/galaxy/pull/12884

Tomorrow I'll work on

mr-c commented 2 years ago

Next up for me:

dakariakin commented 2 years ago

also done with

I'll work on lib/galaxy/model/__init__.py on separate PR because it throws 119 errors

mr-c commented 2 years ago

Building off of @dakariakin 's https://github.com/galaxyproject/galaxy/pull/12884/ I will work on the following next:

mr-c commented 2 years ago

I updated the list at the top, and I'll be working on the new entries from the bottom up

dakariakin commented 2 years ago

I've just created an MR with typings for lib/galaxy/model/init.py https://github.com/galaxyproject/galaxy/pull/12971

Could you please review it?