Closed illusional closed 5 years ago
Merging #15 into master will increase coverage by
1.66%
. The diff coverage is97.77%
.
@@ Coverage Diff @@
## master #15 +/- ##
==========================================
+ Coverage 76.28% 77.95% +1.66%
==========================================
Files 6 6
Lines 544 576 +32
==========================================
+ Hits 415 449 +34
+ Misses 129 127 -2
Impacted Files | Coverage Δ | |
---|---|---|
cwlgen/__init__.py | 76.19% <100%> (ø) |
:arrow_up: |
cwlgen/elements.py | 98.38% <97.72%> (+8.38%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 39a8e51...fecd37d. Read the comment docs.
Branched on the changes from #13, so that should be merged first. This change is my proposal for #14.
I'm not super stoked with the placement of the class definition for
CommandInputArraySchema
, but without a major restructure not sure how I could reducer circular dependencies. My proposal for this would be to have a file for each type, and the way CWL is structured you shouldn't have any circular dependencies. This might help with adding to the Workflow conversion.