search

common-workflow-lab / wdl-cwl-translator

A translator from WDL to CWL v1.2
Apache License 2.0
26 stars 8 forks source link

implement read_lines() with a functional test #181

Closed mr-c closed 2 years ago

mr-c commented 2 years ago

also fix read_tsv() and add functional test

Fixes #175

mr-c commented 2 years ago

@kinow I think we need a new reviewing rule: no new javascript without functional CWL test compared to the miniwdl output :-)

codecov[bot] commented 2 years ago

Codecov Report

Merging #181 (6ed99f0) into main (48a1569) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #181   +/-   ##
=======================================
  Coverage   93.70%   93.70%           
=======================================
  Files           3        3           
  Lines         667      667           
  Branches      196      196           
=======================================
  Hits          625      625           
  Misses         17       17           
  Partials       25       25
Impacted Files Coverage Δ
wdl2cwl/main.py 93.69% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 48a1569...6ed99f0. Read the comment docs.

kinow commented 2 years ago

(will finish review during lunch break in some hours :+1: )