search

common-workflow-lab / wdl-cwl-translator

A translator from WDL to CWL v1.2
Apache License 2.0
26 stars 8 forks source link

improve support for struct literals #188

Closed mr-c closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #188 (d6e9492) into main (049e28b) will increase coverage by 0.17%. The diff coverage is 95.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #188      +/-   ##
==========================================
+ Coverage   94.59%   94.77%   +0.17%     
==========================================
  Files           3        3              
  Lines         703      727      +24     
  Branches      206      216      +10     
==========================================
+ Hits          665      689      +24     
+ Misses         15       14       -1     
- Partials       23       24       +1
Impacted Files Coverage Δ
wdl2cwl/main.py 94.81% <95.34%> (+0.18%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 049e28b...d6e9492. Read the comment docs.

kinow commented 2 years ago 
2022-02-17T21:15:10.6054285Z Running: cwltool --cachedir cache --debug --outdir=/tmp/tmpfgxbln8g cwl_files/literal_struct.cwl
2022-02-17T21:15:11.0531846Z INFO /opt/hostedtoolcache/Python/3.10.2/x64/bin/cwltool 3.1.20220217190813
2022-02-17T21:15:11.0548530Z INFO Resolved 'cwl_files/literal_struct.cwl' to 'file:///home/runner/work/wdl-cwl-translator/wdl-cwl-translator/wdl2cwl/tests/cwl_files/literal_struct.cwl'
2022-02-17T21:15:12.7744097Z usage: cwl_files/literal_struct.cwl [-h] --six.one SIX.ONE --six.two SIX.TWO
2022-02-17T21:15:12.7744727Z                                     [job_order]
2022-02-17T21:15:12.7777211Z cwl_files/literal_struct.cwl: error: the following arguments are required: --six.one, --six.two
2022-02-17T21:15:12.8676041Z Test 18 failed: cwltool --cachedir cache --debug --outdir=/tmp/tmpfgxbln8g cwl_files/literal_struct.cwl
mr-c commented 2 years ago

Yeah, this depends on https://github.com/common-workflow-language/cwltool/pull/1623 and a new release of cwltool