common-workflow-language / cwl-v1.2

Released CWL v1.2.1 specification
https://www.commonwl.org/v1.2/
Apache License 2.0
34 stars 22 forks source link

Workflow output type appears to be incorrect in tests cond-wf-011, cond-wf-011_nojs #147

Closed jdidion closed 1 year ago

jdidion commented 2 years ago

In these two tests, the expected output type is array[array[array[string]]], however the expected output value has nulls in the inner array. Therefore, it seems that the expected output type should be array[array[array[string?]]].

out1:
      [
        [
          [ null, "112", null, "114" ],
          [ null, "122", null, "124" ],
          [ null, "132", null, "134" ]
        ],
        [
          [ null, "212", null, "214" ],
          [ null, "222", null, "224" ],
          [ null, "232", null, "234" ]
        ]
      ]
mr-c commented 2 years ago

Thanks for this report, seems to be the same issue as #146

jdidion commented 2 years ago

I just don't understand - why bother having optional types at all if any type can effectively be optional?

GlassOfWhiskey commented 1 year ago

@jdidion @mr-c @kinow this seems to be solved by 149. Can we close it?