search

common-workflow-language / cwl-v1.2

Released CWL v1.2.1 specification
https://www.commonwl.org/v1.2/
Apache License 2.0
32 stars 22 forks source link

enhance sort order conformance test to test for consistent ordering, but not a specific locale #233

Open mr-c opened 7 years ago

mr-c commented 7 years ago

Or just to the (unwritten) implementation guidance doc?

https://twitter.com/biocrusoe/status/864700272722944001

mr-c commented 6 years ago

At today's meeting we have come to the conclusion that we should default to C for now

mr-c commented 6 years ago

new plan:

  1. No more default locale.
  2. Duplicate https://github.com/common-workflow-language/common-workflow-language/blob/master/v1.0/v1.0/glob_test.cwl with a different "wrong" order
  3. Add step to compare of glob_test.cwl and glob_test2.cwl, fail if not matching
  4. Document in v1.1 v1.2.1 that glob sort orders must be consistent.
mr-c commented 6 years ago

Also confirm that when an array of patterns is passed to glob that each result is sorted, but not all together. Thanks to @milos-ljubinkovic for finding this!

tom-tan commented 5 years ago

Hi.

The reason why I opened common-workflow-language/common-workflow-language#801 is that the behavior of glob with array is not documented and that the actual behavior in cwltool (that passes both of 121 and 172) seems to be inconsistent for me. If the behavior is documented in the spec, it is OK for me.

mr-c commented 1 year ago

@tetron @mvdbeek @GlassOfWhiskey and I affirmed the plan in https://github.com/common-workflow-language/cwl-v1.2/issues/233#issuecomment-1511620172 today

@GlassOfWhiskey reminded us that cwltest might need an upgrade to ignore the order of arrays..