common-workflow-language / cwl-v1.2

Released CWL v1.2.1 specification
https://www.commonwl.org/v1.2/
Apache License 2.0
34 stars 22 forks source link

Add JSON schema for CWL and conformance tests validating it #256

Closed fmigneault closed 1 year ago

fmigneault commented 1 year ago

Changes

References

netlify[bot] commented 1 year ago

Deploy Preview for cwl-v1-2-dev ready!

Name Link
Latest commit 898e922dff4fb19cb484c1c0658a01c7de0868fa
Latest deploy log https://app.netlify.com/sites/cwl-v1-2-dev/deploys/64b7c342d2d5e2000856d19b
Deploy Preview https://deploy-preview-256--cwl-v1-2-dev.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

fmigneault commented 1 year ago

@mr-c Is there anything left to be done for this PR?

mr-c commented 1 year ago

@mr-c Is there anything left to be done for this PR?

Hmm. Do you know why the tests aren't running?

https://github.com/common-workflow-language/cwl-v1.2/actions/runs/5543764240/jobs/10120239133#step:8:1

fmigneault commented 1 year ago

@mr-c Everything works now except the 2 tests related to https://github.com/common-workflow-language/cwl-v1.2/issues/251

fmigneault commented 1 year ago

@mr-c Adjusted and passing! 🚀

fmigneault commented 1 year ago

@mr-c I think the time limit recently introduced might cause a problem because I add a whole set of tests for the JSON schema. https://github.com/common-workflow-language/cwl-v1.2/commit/c2ac7e32b1cfc83f2513bdcddd9c528cc572d719

The error in 32e595a is caused by something else completely unrelated to passing test in 56ebd34

fmigneault commented 1 year ago

@mr-c Thanks!