search

common-workflow-language / cwl-website

www.commonwl.org
Apache License 2.0
11 stars 20 forks source link

Duplicated CWL type definitions? #153

Open fmigneault opened 1 year ago

fmigneault commented 1 year ago

When looking at the list of CWL type items, the "base" items (excluding File and Directory) seem to be duplicated.

I'm not sure if the issue is generated by the website itself, or via the included files from specific CWL version repositories.

For example: https://www.commonwl.org/v1.2/CommandLineTool.html#CWLType Displays the following: image

mr-c commented 1 year ago

I can confirm, this started in https://github.com/common-workflow-language/common-workflow-language.github.io/commit/dced5a1f8d4892548c90673e9e1532ad2a13a163#diff-8825bc9bf39f582c98c2f21f99236bc8d5cbd8de810f3c5fa15a058f7249c3aaL1505 from August 27th

Here is the contents of the CWL v1.2 repo at that time: https://github.com/common-workflow-language/cwl-v1.2/tree/6f15395c3a9c574d7dfb82b2fb19939ceb0d5822

from this run: https://ci.arvados.org/view/CWL/job/cwl-website/164/ which was triggered by this change of cwltool containers: https://github.com/common-workflow-language/cwl-website/commit/7771bb57c6bdb38973855256698d99eab13bd2b6

cwltool_modules:main was https://quay.io/repository/commonwl/cwltool_module/manifest/sha256:9a1877d5e5b861e86aac9672352029505e5ec05e6a3375d6a055e9dc9de426dd

and at that time in August cwltool_module:latest was https://quay.io/repository/commonwl/cwltool_module/manifest/sha256:52623ab058aca137a1af55623cbe7ea6a6674b75dd7f2b12b3653b22505e4bdb

The changes in schema-salad at that time were mostly typing related: https://github.com/common-workflow-language/schema_salad/compare/8.3.20220801194920...8.3.20220825114525#diff-1dd6b4c367fe6344b7d49fb0b0aa3f83a8aa3559bd47b59e084208d27765cae3R6

so it may have been an older change to schema-salad that had not been picked up in the cwltool_module container ...