common-workflow-language / cwlcon2024

Website for the 2024 CWL Conference
https://www.commonwl.org/conferences/2024/
GNU General Public License v3.0
1 stars 0 forks source link

Add 2 columns, add cards (avatars/organizers), placeholder for map, and a few more CSS improvements #48

Closed kinow closed 8 months ago

kinow commented 9 months ago

Closes #26 Closes #29

I built this on top of #47 , but if others prefer I can push to that one and have everything reviewed in a single PR (otherwise I will rebase and resolve any conflicts here later).

Some screenshots below, large and smaller viewports (images are not final, nor text/colors/etc., feel free to suggest any changes).

image

image

kinow commented 9 months ago

After these two, over the next days I will submit one or two other PRs for SEO tags (so it's easier to search/find now and after the conf), and for accessibility (improve contrast, use WAVE to test it, and use a screen reader to navigate the site :+1: ). Then I think the site layout tasks will be over, and I will focus on that Zotero list and translate/contribute-a-thon :wave:

alexiswl commented 9 months ago

This looks great! How does it handle when the columns aren't of equal length? i.e Registrations page will be a short paragraph while the Program contents will likely become quite long?

kinow commented 9 months ago

This looks great! How does it handle when the columns aren't of equal length? i.e Registrations page will be a short paragraph while the Program contents will likely become quite long?

In that case it might be easier to shuffle things around to find some balance

It will just keep the content of both aligned at the top, both columns with the same height.

kinow commented 9 months ago

I was creating a separate PR when I realized it would be simpler to push a commit here. Last commit updates the venue (confirmed with @mr-c via element). I used the details from the university website, copying the exact Google Maps link. The address was added with the <address> HTML tag as that simplifies for SEO and when there tools/browsers to identify there is an address in that page.

Leaving the date for the week until we have defined the agenda for the online part too, and other timezones, etc.

image

alexiswl commented 9 months ago

@kinow are you happy to merge this?

kinow commented 9 months ago

@kinow are you happy to merge this?

Was waiting to see if @mr-c wanted to review this one too.