switch to another javascript linter, jshint is non-free

common-workflow-language / cwltool

Common Workflow Language reference implementation

https://cwltool.readthedocs.io/

Apache License 2.0

335 stars 230 forks source link

switch to another javascript linter, jshint is non-free #1020

Closed mr-c closed 2 years ago

mr-c commented 5 years ago

https://github.com/jshint/jshint/blob/master/src/jshint.js

The Software shall be used for Good, not Evil.

https://wiki.debian.org/qa.debian.org/jsonevil

Might have to remove this in the meantime :-(

mr-c commented 5 years ago

Looks like eslint might be a good candidate: https://eslint.org/docs/developer-guide/nodejs-api#linter npm-bundle produces a 3.4MB tarball; we need to find a way to get that down to a single javascript file...

kinow commented 2 years ago

I remember seeing jshint in some projects some time ago, but in the past few years I've only used eslint. Might be able to tackle this one when I find time (good to check what's the status of the latest eslint, I think I'm using older versions).

mr-c commented 2 years ago

Oh, this was fixed in https://github.com/common-workflow-language/cwltool/commit/f0a844af6f93883fcacb3572a6366124a50d0909 !