search

common-workflow-language / cwltool

Common Workflow Language reference implementation
https://cwltool.readthedocs.io/
Apache License 2.0
324 stars 225 forks source link

add the --shm-size parameter at runtime #1972

Closed lihl2014 closed 5 months ago

lihl2014 commented 5 months ago

Fixes #1821
https://github.com/common-workflow-language/cwltool/issues/1821#issuecomment-1481347082

mr-c commented 5 months ago

Thank you for this @lihl2014 ; do you know what the equivalent options for podman and singularity/apptainer are?

mr-c commented 5 months ago

For podman, looks like it has the same option name: --shm-size ; but for apptainer/singularity there doesn't seem to be such an option

https://docs.podman.io/en/latest/markdown/podman-run.1.html#shm-size-number-unit

codecov[bot] commented 5 months ago

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fe1e8a9) 83.75% compared to head (6c254b0) 83.80%.

Files Patch % Lines
cwltool/singularity.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1972 +/- ## ========================================== + Coverage 83.75% 83.80% +0.04% ========================================== Files 46 46 Lines 8231 8235 +4 Branches 2186 2187 +1 ========================================== + Hits 6894 6901 +7 + Misses 860 858 -2 + Partials 477 476 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mr-c commented 5 months ago

Thank you @lihl2014 !