Open vjaganat90 opened 1 week ago
Attention: Patch coverage is 66.66667%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 83.96%. Comparing base (
9473f13
) to head (4700f30
). Report is 4 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
cwltool/command_line_tool.py | 66.66% | 1 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thank you @vjaganat90 ! I've made a note to turn your example into a new conformance test for CWL: https://github.com/common-workflow-language/cwl-v1.3/issues/31
The issue is when we print 2d_output arrays which have "format" tag
touch filename.txt
cwltool --cachedir foo output_2D_file_format.cwl
The crux of the issue is aslist function, only promotes scalars to 1d arrays. Arbitrary JS can return an arbitrary json, format handling code needs to handle arbitrary json (not just scalars or 1d arrays which is done through aslist function).
With this fix the output should be something like this