Closed mr-c closed 7 years ago
Comments on the wording are appreciated, especially from @jvdzwaan
Hi Michael, Can you explain if default container isn't used don't show this warning
. But on windows all execution is happening under docker container, so I guess default container is always used, isn't it. Do you mean if external Container is already provided.
Good idea to add a warning! I would make it more explicit that all steps without a docker hint/requirement will be executed in the default container. Something like:
We are on Microsoft Windows and not all components of this CWL description have a
container specified. This means that these steps will be executed in the default container,
which is %s.
Also, I don't understand why you would advise to add a hint for the default container. Shouldn't we advise them to use a more appropriate container if they have non-POSIX features in their CWL?
@kapilkd13 correct, if all components of the Workflow, CommandLineTool, or ExpressionTool have a DockerRequirement
or inherit a DockerRequirement
(except from the --default-container
or the Windows fallback default container) then the warning should be printed under Windows.
@jvdzwaan The default container used by cwltool
could change over time. Your idea that there should be a note suggesting that (if needed) the user should specify another container, is a good idea.
Fixed in #492
But if the default container wasn't needed then don't mention it.
Warning text (may need to be refined):