search

common-workflow-language / cwlviewer

A web application to view and share Common Workflow Language workflows
https://view.commonwl.org/
Apache License 2.0
44 stars 28 forks source link

permalink not visible on small screens #485

Open mr-c opened 1 year ago

mr-c commented 1 year ago

Example https://view.commonwl.org/workflows/github.com/BD2KGenomics/dockstore_workflow_fusion/blob/master/fusion_workflow.cwl

Neither in mobile view, portrait mode

Screenshot_20221230-102402

Horizontal mode Screenshot_20221230-102411

Nor desktop mode Screenshot_20221230-102432

kinow commented 1 year ago

Looks like it was intentionally hidden on smaller viewports (CSS class hidden-xs).

The verified link: https://github.com/common-workflow-language/cwlviewer/blob/492770e7aed67722d35959e05b0fa0a058fbb17f/src/main/resources/templates/workflow.html#L144-L146

And the permalink: https://github.com/common-workflow-language/cwlviewer/blob/492770e7aed67722d35959e05b0fa0a058fbb17f/src/main/resources/templates/workflow.html#L154-L159

mr-c commented 1 year ago

Thanks for the quick sleuthing @kinow !

I think permalinks are pretty important, though I can see how they could screw up the layout. Maybe the intention was to just display an icon for small displays instead of the full URL?

kinow commented 1 year ago

That would make more sense, the smaller icon. I think the verified icon could also be displayed although it is useful to know the cwltool version as well.