search

common-workflow-language / cwlviewer

A web application to view and share Common Workflow Language workflows
https://view.commonwl.org/
Apache License 2.0
44 stars 28 forks source link

Review Jena dependencies in CWLViewer #498

Open kinow opened 1 year ago

kinow commented 1 year ago

Description

It appears we are using Jena 3.x API, even though we have Jena 4.x in the dependencies. It's being brought into the code via Taverna: https://github.com/apache/jena/issues/1293#issuecomment-1372712597

Expected Behavior

Use latest Jena 4.x

Actual Behavior

Possible Fix

Use updated API.

Steps to Reproduce

1. 2. 3. 4.

Context

Your Environment

kinow commented 1 year ago

See comments in the linked issue in jena, e.g.

Not sure if CWLViewer is using Jena 4 and 3 at the same time.

Jena uses ServiceLoader to initialize so if jars from both on the classpath, then, yes, it is both (jena-core from v4, RIOT from v3). Since 3.0.1, RIOT plugged itself into jena-core as an RDFReader.

This is (not) going to be fun to tackle this issue, I think.