better handle IOExceptions when scanning an entire directory - Githubissues

common-workflow-language / cwlviewer

A web application to view and share Common Workflow Language workflows

https://view.commonwl.org/

Apache License 2.0

45 stars 28 forks source link

better handle IOExceptions when scanning an entire directory #500

Closed mr-c closed 1 year ago

mr-c commented 1 year ago

Description

Motivation and Context

When scanning an entire directory, a single IOException (like a malformed YAML document) will return no results, instead of skipping that one workflow

For example: https://github.com/hybridstat/elixir-gr-project/tree/dc1b566523dc4d6f65032d40f8d4e716d7cb339f/CWL/workflows

Gives

Whoops - Something Went Wrong! Error: An internal server error occurred

Instead of skipping https://github.com/hybridstat/elixir-gr-project/blob/dc1b566523dc4d6f65032d40f8d4e716d7cb339f/CWL/workflows/mapping-se-qc-r.cwl#L44 due to the missing :

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.