Upgrading to Spring Boot 3

common-workflow-language / cwlviewer

A web application to view and share Common Workflow Language workflows

https://view.commonwl.org/

Apache License 2.0

44 stars 28 forks source link

Upgrading to Spring Boot 3 #568

Closed kinow closed 1 month ago

kinow commented 1 year ago

Description

Upgrading to Spring Boot 3

Motivation and Context

https://github.com/common-workflow-language/cwlviewer/pull/566#issuecomment-1735611928

Closes #576

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have added tests to cover my changes.
[ ] All new and existing tests passed.

kinow commented 1 year ago

Fixed one broken test today, three more to go. Two I know the reason, but not the solution. The other we had during the migration mongo->postgres, so I just need to find the notes about how to debug that one (need to look at the query executed during the unit test...)

kinow commented 2 months ago

The last test failing is due to Hibernate/Postgres. At least the others were fixed (at least locally, waiting for GH Actions). Time to search for issues/SO's/etc now :grimacing:

kinow commented 2 months ago

Finally had some time to give it another try, and managed to get all tests passing. Still a couple of points pending, and I will try to do some manual tests using existing CWL workflows. But feel free to review or test it if you have time -- I will test it next time I have a chance, but at least we now have a working build with updated Spring Boot and dependencies :wave:

mr-c commented 1 month ago

@kinow Shall I merge?

kinow commented 1 month ago

@kinow Shall I merge?

Let me rebase, and then do some quick tests with Docker locally. Then it should be ready to go! :boom:

kinow commented 1 month ago

@mr-c rebased, GH Actions passed, then checked out latest commit, ran docker compose up, uploaded some CWL files, they were all correctly rendered. I think it's ready to be merged now :slightly_smiling_face: Thanks!

mr-c commented 1 month ago

Huzzah!