common-workflow-language / cwlviewer

A web application to view and share Common Workflow Language workflows
https://view.commonwl.org/
Apache License 2.0
44 stars 27 forks source link

error improvements #587

Open mr-c opened 9 months ago

mr-c commented 9 months ago

Description

When the use provides a path to a CWL document that is not class: Workflow or a $graph containing a class: Workflow, we need a better error message than Error: The workflow could not be found within the repository

Motivation and Context

Fixes #582

How Has This Been Tested?

I tested locally with the provided Git repository URL, branch, and path in the original issue.

Screenshots (if appropriate):

image

Types of changes

Checklist:

mr-c commented 9 months ago

@kinow Could you add a test? I'm not familiar with the testing framework

kinow commented 9 months ago

@kinow Could you add a test? I'm not familiar with the testing framework

Sorry, saw this comment before approving. Let me take a look…

kinow commented 3 months ago

(Clicked on Update branch -- forgot to check if there was an option to rebase...)