Open jmfernandez opened 2 years ago
@jmfernandez Thanks for the report, it explains some recent failures I'm seeing (also using raw.github links): https://github.com/common-workflow-language/cwltool/runs/4051426410?check_suite_focus=true#step:8:3833
Either a dependency of requests
got updated, or there was a change in GitHub's infrastructure..
This issue is related to
schema_salad.fetcher.DefaultFetcher.fetch_text
, and it is a bit difficult to reproduce. I have found it this late afternoon, when I tried next cwltool commands:The issue is difficult to reproduce as it has appeared for me only from wireless. But I was unable to reproduce it from my workstation, for instance. When it fails the output is similar to next, but the intermediate stack trace is variable:
Digging in cwltool and later in schema_salad I found that, sometimes next block returns what it is expected, sometimes it returns an empty string:
https://github.com/common-workflow-language/schema_salad/blob/5d45ae6cdc4b9896d6e305b4372cb8aef3e42238/schema_salad/fetcher.py#L59-L75
It seems some weird behavior in
requests
library, where it does not materialize the full response of the request when the property is read (but I'm guessing, as I'm not a frequent user of such library). I guess that because I did a quick'n'dirty test, substitutingrequests
library calls byurllib.request
ones (see code below), and it started working:Hope this helps to anyone else having this issue!