Open denis-yuen opened 8 years ago
FYI, I was able to compile with this following trivial change to the cwl-avro.yml.
$ git diff
diff --git a/draft-3/cwl-avro.yml b/draft-3/cwl-avro.yml
index b3ae433..c6310e1 100644
--- a/draft-3/cwl-avro.yml
+++ b/draft-3/cwl-avro.yml
@@ -1117,8 +1117,8 @@
name: CWLVersions
doc: "Version symbols for published CWL document versions."
symbols:
- - draft-3.dev1
- - draft-3.dev2
+ - draft3dev1
+ - draft3dev2
- type: record
name: CommandLineBinding
Hello @denis-yuen,
I think this is fixed with https://github.com/common-workflow-language/cwlavro, yes? Thanks again for all your assistance; I appreciate it!
Hi, Not exactly. We use the workaround noted above which works for generating cwlavro. However, I think there is still value in schema-salad generating a valid avro schema. Not only would that remove the above workaround, more importantly, that should make things simpler if an implementer in a different language attempts the same process of generating an sdk.
i.e. schema salad when converting the CWL spec to an avsc should strip out characters that are valid in CWL but not valid in avsc
@denis-yuen I assume this is still a problem. The generated avsc could easily be sanitized, however without being a bit more clever I expect the result will just be that it won't recognize the symbols as defined in the original schema. Perhaps the workaround is to convert fields that use enum types with invalid chars into string fields?
@tetron that sounds reasonable as well
Hi,
This may be a followup to https://github.com/common-workflow-language/common-workflow-language/issues/69 unless I'm mixing something up.
I'm using the current version of common-workflow-language (although the two tags don't seem to fare much better).
When I use the schema_salad project to generate an avro schema, that succeeds.
However, when I attempt to compile the schema, the following happens: