Improved c++ code generation when template are involved

common-workflow-language / schema_salad

Semantic Annotations for Linked Avro Data

https://www.commonwl.org/v1.2/SchemaSalad.html

Apache License 2.0

72 stars 62 forks source link

Improved c++ code generation when template are involved #744

Closed SGSSGene closed 11 months ago

SGSSGene commented 11 months ago

This fixes two things:

Fixes c++ code generation bug: every child class received a copy of all items, additional to inheriting them. This is now fixed.
Rewrote the code, producing input/output parameter, allowing for nested parameters.
If a mapSubject is given, the generated code will convert "list with ids" to a map.

codecov[bot] commented 11 months ago

Codecov Report

Merging #744 (60818b8) into main (f098da4) will increase coverage by 0.10%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #744      +/-   ##
==========================================
+ Coverage   83.50%   83.60%   +0.10%     
==========================================
  Files          22       22              
  Lines        4510     4538      +28     
  Branches     1212     1226      +14     
==========================================
+ Hits         3766     3794      +28     
  Misses        482      482              
  Partials      262      262

Files	Coverage Δ
schema_salad/cpp_codegen.py	`80.80% <100.00%> (+1.99%)`	:arrow_up:

SGSSGene commented 11 months ago

Hello, can someone help me out with the CI run doc/readthedocs.org:schema-salad? I don't understand what is going on. It seems to be an error according to dotnet_codegen.py, which I didn't touch.

mr-c commented 11 months ago

All fixed; thank you @SGSSGene !