Closed GlassOfWhiskey closed 9 months ago
Merging #760 (9c2a011) into main (990d856) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## main #760 +/- ##
=======================================
Coverage 83.68% 83.68%
=======================================
Files 22 22
Lines 4580 4580
Branches 1239 1239
=======================================
Hits 3833 3833
Misses 483 483
Partials 264 264
Files | Coverage Δ | |
---|---|---|
schema_salad/codegen.py | 94.64% <100.00%> (ø) |
|
schema_salad/codegen_base.py | 100.00% <ø> (ø) |
|
schema_salad/dotnet_codegen.py | 95.75% <ø> (ø) |
|
schema_salad/java_codegen.py | 91.10% <ø> (ø) |
|
schema_salad/python_codegen.py | 93.65% <ø> (ø) |
|
schema_salad/typescript_codegen.py | 95.95% <ø> (ø) |
Looks like it is working! Can we have an updated cwl-utils PR to evaluate the result?
This commit introduces support for the
noLinkCheck
jsonldPredicate
in the Schema SALAD codegen toolchain, and in particular in theURILoader
stack. WhennoLinkCheck
is set totrue
, no link checking is performed for all the underlying objects hierarchy. The need to propagate its value to the hierarchy makes it necessary to modify also theLoadingOptions
data structure.All parsers but the Python one never perform link checking up to now, so this update makes no modification to their actual behaviour. However, it enables the
URILoader
classes to receive thenoLinkCheck
parameter for future implementations.