common-workflow-language / schema_salad

Semantic Annotations for Linked Avro Data
https://www.commonwl.org/v1.2/SchemaSalad.html
Apache License 2.0
72 stars 60 forks source link

fixes #805 The value of copyFrom.fetcher is not used in the LoadingOp… #806

Closed bioflowy closed 3 months ago

bioflowy commented 4 months ago

The LoadingOptions.fetcher must be the same as the fetcher specified in the constructor's copyFrom, but it is not. Initially, the value of copyFrom.fetcher is set to this.fetcher, but it is always overwritten later by the fetcher specified in the arguments or by DefaultFetcher. I have corrected this by setting copyFrom.fetcher to fetcher instead of this.fetcher.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.35%. Comparing base (2378312) to head (830ee9b). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #806 +/- ## ======================================= Coverage 83.35% 83.35% ======================================= Files 22 22 Lines 4818 4818 Branches 1303 1303 ======================================= Hits 4016 4016 Misses 527 527 Partials 275 275 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.