search

common-workflow-language / user_guide

The CWL v1.0 - v1.2 user guide
http://www.commonwl.org/user_guide/
Other
42 stars 67 forks source link

2022 Week 44 release #337

Closed mr-c closed 1 year ago

swzCuroverse commented 1 year ago

My initial review.

It would be nice if more of this was caught during the original PRs, @tetron

Also, the commit messages are very uninformative. Either PRs should be squashed and the commit message updated, or contributors should be asked to clean up their commits.

@mr-c you point out several issues where people have including v1.0, command-line or FAQ titles that aren't questions. However that was done all ready in the user guide. So, I am not sure why @tetron was responsible for pointing them out since they are already inconsistent in the User Guide which you reviewed. I think if you want a standard or consistent use (1) you should document it (2) you should make sure it is in the User Guide correctly. Otherwise, there is no way people will know that is what you want.

tetron commented 1 year ago

@mr-c I believe branch protection on main is interfering with "Update branch" and "Commit suggestion" buttons, so I was going to close this pull request and make a new branch called staging.

tetron commented 1 year ago

See #373