fix: add number and bigint checks

commonbaseapp / zodex

The missing zod (de/)serialization library

https://commonbaseapp.github.io/zodex/

MIT License

49 stars 5 forks source link

fix: add number and bigint checks #3

Closed brettz9 closed 1 year ago

brettz9 commented 1 year ago

Hi,

Thought I'd try adding a few... Does this work for you?

brettz9 commented 1 year ago

There's one challenge though... Currently, the code is not adding "inclusive" to indicate that min and max are in fact inclusive (other operations like gt will lead to it being false). Should I go ahead and change the existing JSON to expect inclusive when it is so?

brettz9 commented 1 year ago

@Gregoor : Note that I also have some other PRs I can submit, but I figure I'd just confirm first that my format is acceptable (and also in the case here, know if you wanted me to add inclusive: true as I would expect should be needed)