search

commoncrawl / cc-pyspark

Process Common Crawl data with Python and Spark
MIT License
406 stars 86 forks source link

Variable data_type is incorrectly used #31

Closed praveenr019 closed 2 years ago

praveenr019 commented 2 years ago

This commit fixes below error, while running get-data.sh get-data.sh: line 20: Downloading Common Crawl paths listings (${data_type^^} files of $CRAWL)...: bad substitution

sebastian-nagel commented 2 years ago

Hi @praveenr019, the usage of "${var^^}" is intentional - it converts the variable value to uppercase characters. This is bash-specific syntax, possibly not supported by other shells. Which shell did you use?

praveenr019 commented 2 years ago

Thanks for the response.

I was using zsh actually. Feel free to close this issue.

sebastian-nagel commented 2 years ago

Thanks, @praveenr019!