search

commoncriteria / transforms

Repository for various transforms that are common across CC projects.
The Unlicense
1 stars 2 forks source link

formatting of PP reference when threat inherited from Base-PP #88

Closed jfisherbah closed 9 months ago

jfisherbah commented 9 months ago

In PP-Modules we currently have the ability to bring a threat in from a Base-PP for the purpose of mapping it to an objective in the Module. See for example section 4.3 of (https://commoncriteria.github.io/email-client/master/email-client.html). However, there appears to be no way to put a space in the referenced PP name.

The actual code uses a tag where 'base' must be the same as the 'id' parameter of a . However, it then just puts the actual id value as-is in brackets. Since the id value can't contain spaces, this creates inaccurate references. So for example, instead of saying "from [App PP]" which is the desired behavior, it must say "from [AppPP]" because there's no way to override the 'id' value (that can't contain a space).

More a nuisance cosmetic issue than an actual problem but worth flagging.

robertmclemons commented 9 months ago

I think this is fixed. Now it produces "App PP" rather than "AppPP."

jfisherbah commented 9 months ago

confirmed fixed