commonknowledge / leftbookclub

Website for the Left Book Club
https://leftbookclub.com
GNU General Public License v3.0
5 stars 0 forks source link

Migrate existing subscribers from the generic `Left Book Shop Subscription` product to new fulfilment-oriented products #193

Closed janbaykara closed 2 years ago

janbaykara commented 2 years ago

The product in question: https://dashboard.stripe.com/products/prod_DctmmNsQ5TOdQC

janbaykara commented 2 years ago

@melaniepatrick just to confirm that the fulfilment plan for this month is that you'll use the existing spreadsheet for customers on the old product, the admin-based fulfilment spreadsheet generator for 2020 and new website product subscriptions, and no technical changes are required right now?

I think the long term solution is to silently migrate these old product subscriptions onto the current products with the same pricing. This might actually turn out to be quite a trivial thing to do.

janbaykara commented 2 years ago

Discussion today:

janbaykara commented 2 years ago

@melaniepatrick status report: I'm about halfway through writing the script for migrating customers from the old products to the new products on stripe, to make fulfillment export files 'complete'.

It's getting late in the day and the end of the week, and I need to head off for the evening.

Would we be able to cover the migrating the legacy stripe products to the new stripe products on Monday, or is that really too late?

janbaykara commented 2 years ago

@melaniepatrick the migration of Stripe subscriptions to the new products is now under way. You'll see from this screenshot that in the next invoice (whose date is the same as before) the product switchover happens without any change to pricing:

Image

https://dashboard.stripe.com/subscriptions/sub_1K5qhlKYdS0VccAEbQQDanAA

janbaykara commented 2 years ago

Migration is complete except for:

janbaykara commented 2 years ago

Hi again @melaniepatrick.

OK, all members are now migrated over to the new products.

The fulfillment export spreadsheet has all the required columns, and I've confirmed that download is working reasonably fast.

You should now be able to download the full list of active members for delivery purposes. Please create new Github issues for any further fulfillment issues.

Cheers and have a good weekend!

melaniepatrick commented 2 years ago

Thanks Jan I've just had a look at the excel download and I have a question that it would be useful to sort out on Monday. When I download all active subscribers there are a lot more than I expected. 1237. Whereas Stripe tells me we have 1190 active members.

Are we perhaps including gift buyers in this list?

Have a good weekend, we can sort out next week. thanks Mel

On Thu, Jun 9, 2022 at 2:26 PM Jan Baykara @.***> wrote:

Migration is complete except for:

  • Customers like this https://dashboard.stripe.com/subscriptions/sub_1KvMhIKYdS0VccAEEMwevIvM who had gift recipient subscriptions set up for them manually as part of the website migration.
    • Switch them onto a new product based on the gift giver subscription product
    • Apply the relevant Gift Card for that new product
  • Transition remaining Gift Card subscriptions to the new Gift Cards

— Reply to this email directly, view it on GitHub https://github.com/commonknowledge/leftbookclub/issues/193#issuecomment-1151117742, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYBPO5YWHXOADC2TEQUIAOTVOHWH7ANCNFSM5VITORPQ . You are receiving this because you were mentioned.Message ID: @.***>

janbaykara commented 2 years ago

@melaniepatrick Stripe's definition of "active subscribers" does not include recipients on gift card plans:

How are Active Subscribers calculated? Subscribers are counted as “active” if they have at least one subscription that is "active". We count any subscription as "active" for which at least one invoice has been paid and which are in the status=active and status=past_due states.

Gift recipients will not ever have had an invoice paid, as they aren't billed for any amount.

janbaykara commented 2 years ago

@melaniepatrick also, we are explicitly filtering out gift giver subscriptions from this list, so they do not show up in the export:

https://github.com/commonknowledge/leftbookclub/blob/889313043900a9007db4c2fe8a851ca4fd621f1e/app/wagtail_hooks.py#L141-L146

melaniepatrick commented 2 years ago

That's correct, thanks. Yes going forward that could work.

On Sat, May 7, 2022 at 11:33 PM Jan Baykara @.***> wrote:

@melaniepatrick https://github.com/melaniepatrick just to confirm that the fulfilment plan for this month is that you'll use the existing spreadsheet for customers on the old product, and no technical changes are required right now?

I think the long term solution is to silently migrate these old product subscriptions onto the current products with the same pricing. This might actually turn out to be quite a trivial thing to do.

— Reply to this email directly, view it on GitHub https://github.com/commonknowledge/leftbookclub/issues/193#issuecomment-1120310260, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYBPO56QBVCMML324JKYJHDVI3VUBANCNFSM5VITORPQ . You are receiving this because you were mentioned.Message ID: @.***>