Closed Kyle-Ye closed 2 years ago
Looks good -- I'd only ask that we have init_pos
instead of initPos
for consistency with the style of the rest of the code.
Looks good -- I'd only ask that we have
init_pos
instead ofinitPos
for consistency with the style of the rest of the code.
Seems like initpos would better fit the position here.(startpos and endpos)
init_pos or initpos which do you prefer @jgm
Yes, initpos would be better.
Yes, initpos would be better.
Done.
Could we run test on it again and merge it. cc @jgm
Thanks for this!
See more info and context here https://github.com/apple/swift-cmark/pull/26
In brief: When parse "`A" and "``A" Before the PR: We'll get text sourcepos 1:2-1:2 and 1:3-1:3 After the PR: We'll get text sourcepos 1:1-1:2 and 1:1-1:3