search

commonmark / commonmark-java

Java library for parsing and rendering CommonMark (Markdown)
BSD 2-Clause "Simplified" License
2.31k stars 288 forks source link

Fix LinkReferenceDefinition having null SourceSpan when title is present #310

Closed robinst closed 8 months ago

robinst commented 8 months ago

Fixes #292.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 94.75%. Comparing base (06aa3e5) to head (21fc1df).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #310 +/- ## ============================================ - Coverage 94.75% 94.75% -0.01% Complexity 254 254 ============================================ Files 131 131 Lines 4141 4140 -1 Branches 604 604 ============================================ - Hits 3924 3923 -1 Misses 108 108 Partials 109 109 ``` | [Files](https://app.codecov.io/gh/commonmark/commonmark-java/pull/310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=commonmark) | Coverage Δ | | |---|---|---| | [...onmark/internal/LinkReferenceDefinitionParser.java](https://app.codecov.io/gh/commonmark/commonmark-java/pull/310?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=commonmark#diff-Y29tbW9ubWFyay9zcmMvbWFpbi9qYXZhL29yZy9jb21tb25tYXJrL2ludGVybmFsL0xpbmtSZWZlcmVuY2VEZWZpbml0aW9uUGFyc2VyLmphdmE=) | `96.96% <100.00%> (-0.03%)` | :arrow_down: |