search

commonpike / add-to-calendar-buttons

Easily add a "add to calendar" button to your websites. This JavaScript library supports Google Calendar, Office 365, iCal, Outlook and Yahoo Calendar.
61 stars 17 forks source link

Multiple all day event. #10

Open kpatelneha23 opened 4 years ago

kpatelneha23 commented 4 years ago

Has anyone tried adding, multiple days, all-day events. I am trying to give a date range, but it works if you give a start time and finish time. If you try to make it all day, it does not work.

commonpike commented 4 years ago

I can confirm that .. and considering it a bug. Assigning it to myself.

For ICS (the download), it should remove the T00000 completely on all day events as described here https://stackoverflow.com/questions/31620641/mulit-day-all-day-event

For Google, it should probably ignore the timezone if it's all day (like ICS does). Now, it tries to calculate the day by adding 24 hours, which is only correct for single day events.

I didn't test, but Yahoo and Office365 might already work as they are.

ocouch commented 2 years ago

@commonpike I fixed this but on the original repo: https://github.com/carlsednaoui/add-to-calendar-buttons/pull/39

Sorry, I didn't realise! You can probably merge it into this one without too much trouble.