pehrlich
commented
13 years ago I notice
**
-
paginate(:page => params["page"]) -
paginate(:page => params["page"].to_i + 1)
Does sunspot user a 1-based index rather than 0-based? I was getting funny/frustrating issues with pagination earlier, I guess this would explain it!
Also curious:
- current_user.community.id == community_id.to_i || current_user.admin
Why would community_id ever not be an integer? Seems like a higher-level issue might be afoot. A good/cool/DRY refactor would to move that code in to the authorize! method, which is called as a before filter in the Base class.
Cheers & enjoy big sur!
--Peter
On Thu, Oct 20, 2011 at 5:19 PM, John Poje < reply@reply.github.com>wrote:
positive information for empty searches (invite neighbors, create feeds)
ordering feeds, users by interesting details
replaced invite neighbor button w/ a more appropriate search button
info-box scrolling works on small screens
You can merge this Pull Request by running:
git pull https://github.com/jpojecp/commonplace master
Or you can view, comment on it, or merge it online at:
https://github.com/commonplaceusa/commonplace/pull/68
-- Commit Summary --
- info-box scrollbar doesn't stick between different lists
- failed searches in info-box show message
- search pagination starts at 0
- added info-box no-search-result views
- info-box has detailed message when search returns nothing
- can't use dashes in js var names
- users, feeds order with avatars and descriptions go first
- fixed switching filters in info-box w/ an empty search
- added organizer name, email to community serializer
- fixed checking for the right community
- moved invite link to account profile, added search button
- info-box scrolling accomodates small screens
-- File Changes --
M app/javascripts/info_boxes/base.js (63) M app/javascripts/info_boxes/feed_profile.js (6) M app/javascripts/info_boxes/group_profile.js (13) M app/javascripts/info_boxes/user_profile.js (6) M app/stylesheets/main_page/profile_box.css.sass (29) M app/templates/main_page/info-box.js.mustache (8) M app/templates/main_page/profiles/account-profile.js.mustache (1) A app/templates/main_page/profiles/feed-none.js.mustache (7) A app/templates/main_page/profiles/group-none.js.mustache (7) A app/templates/main_page/profiles/user-none.js.mustache (7) M lib/api/base.rb (2) M lib/api/communities.rb (6) M lib/api/search.rb (2) M lib/serializer.rb (2)
-- Patch Links --
https://github.com/commonplaceusa/commonplace/pull/68.patch https://github.com/commonplaceusa/commonplace/pull/68.diff
Reply to this email directly or view it on GitHub: https://github.com/commonplaceusa/commonplace/pull/68
maxtilford
positive information for empty searches (invite neighbors, create feeds)
ordering feeds, users by interesting details
replaced invite neighbor button w/ a more appropriate search button
info-box scrolling works on small screens