commonplaceusa / commonplace

COMMUNITY!
www.commonplaceusa.com
3 stars 0 forks source link

Whilependingmerge #75

Open pehrlich opened 12 years ago

pehrlich commented 12 years ago

This still needs cross-browser testing, and some quick college i18n, but I figured I'd make a pull request just to kick things off.

Changes in these commits:

I should have some mpq updates on the way here shortly!

pehrlich commented 12 years ago

A few notes & learning experiences from doing this work:

Check out ReCSS! It allows you to re-apply stylesheets without reloading the page. Its a big time-save and helps focus (no js distractions). http://david.dojotoolkit.org/recss.html

when writing css, keep the selector rules as simple as possible. Sass is dangerous, indentation seems harmless but creates inflexible code. Only indent when necessary. Favor adding a new class to some existing markup than a new selector to some existing css. Try and be markup independent, referring only to a minimal set of class names.

when deleting registration.rb, every method deleted was accompanied with a full-text-search note on refactorings like this -- it wasn't a sudden thing. A method was duplicated in the api, then the old one was marked for possible deletion. A number of these were accumulated, then in a batch checked and deleted. As the class began to empty, it to was marked for possible deletion, and the after some refactoring of the views, removed.

In this javascript, there's about as much library code as there is procedural code. Try and logic and flow to a minimum and in one designated sector, with the rest being a toolbox that gets employed. (This also makes things more easy to test, automated or otherwise)

And finally, I'm stoked because I got jquery.validate working with both client and server side errors and that's pretty cool.

Go check out the code! It should be fun!