commonprefix / kevlar

Light client-based RPC Proxy for PoS Ethereum
262 stars 25 forks source link

yarn build fails on unmet dep #8

Closed twtaylor closed 1 year ago

twtaylor commented 1 year ago

https://www.npmjs.com/package/json-rpc-engine doesn't appear to be pulled in properly. If you look at https://github.com/lightclients/kevlar/blob/90b1c7f2f56efa0669368ced93d12c1824f3dbd7/src/rpc-bundle/rpc-lightclient-middleware.ts#L1 the node module json-rpc-engine is not pulled in from anywhere.

So you'll get something like:

> yarn build
yarn run v1.22.19
$ tsc
src/rpc-bundle/rpc-lightclient-middleware.ts:1:39 - error TS2307: Cannot find module 'json-rpc-engine' or its corresponding type declarations.

1 import { createAsyncMiddleware } from 'json-rpc-engine';
                                        ~~~~~~~~~~~~~~~~~

Found 1 error in src/rpc-bundle/rpc-lightclient-middleware.ts:1

error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

If you try to build.

shresthagrawal commented 1 year ago

@twtaylor thanks for reporting the issue is fixed now