commons-app / apps-android-commons

The Wikimedia Commons Android app allows users to upload pictures from their Android phone/tablet to Wikimedia Commons
https://commons-app.github.io/
Apache License 2.0
1.03k stars 1.24k forks source link

Allow users to browse Commons from app #1221

Closed 97balakrishnan closed 6 years ago

97balakrishnan commented 6 years ago

Summary:

My suggestion is to enable the user to access the Mobile version of Wikimedia Commons Website within their app. This would give an integrated feel to the user. I noticed that this has been the main concern with people in playstore reviews. Sorry if this issue has already been discussed

Steps to reproduce: Adding a new activity which would display the mobile version of Wikimedia Commons app using a webView.

KAMiKAZOW commented 6 years ago

Just adapt the Wikipedia app for the browsing part.

nicolas-raoul commented 6 years ago

FastCCI seems to be out of service right now... I asked for an equivalent service at opendata, might be worth asking at the Commons village pump too @ujjwalagrawal17

ujjwalagrawal17 commented 6 years ago

@nicolas-raoul I have asked the same question in Village pump Link: https://commons.wikimedia.org/wiki/Commons:Village_pump#May_08 .

Also I have created an issue in FastCCI repo. Link : https://github.com/Commonists/fastcci/issues/6

maskaravivek commented 6 years ago

@nicolas-raoul @ujjwalagrawal17 Sorry, I am unable to follow the discussion completely. Are we planning to show just the best images in a category or sort the images based on quality?

nicolas-raoul commented 6 years ago

Vivek: Only if times allows. But now is a good time to start asking around whether an appropriate API exists 🙂

On Tue, May 8, 2018, 23:17 Vivek Maskara notifications@github.com wrote:

@nicolas-raoul https://github.com/nicolas-raoul @ujjwalagrawal17 https://github.com/ujjwalagrawal17 Sorry, I am unable to follow the discussion completely. Are we planning to show just the best images in a category or sort the images based on quality?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/commons-app/apps-android-commons/issues/1221#issuecomment-387417966, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGFBouBDPBLbBDzrt30qbVLDKh63jKAks5twakLgaJpZM4SVOVY .

ujjwalagrawal17 commented 6 years ago

@maskaravivek we are planning to show just best images. We are looking for an API that gives us best images sorted based on quality.

maskaravivek commented 6 years ago

Great that we are aiming to show images sorted based on quality! That would be really nice.

I jumped into this discussion just to make sure we don't rebuild things that already exist in the app. :)

Recently we added the featured image section. It uses an activity that is completely generic. It already takes care of the error states, internet connectivity, and scroll to load more option. It simply takes the title of the page and name of the category as intent params. Here's the usage:

CategoryImagesActivity.startYourself(this, "My page title", "Category Name");

I guess, even with sorting added most of the existing pieces can be used as is. :)

maskaravivek commented 6 years ago

@ujjwalagrawal17 Congrats for completing this task. Am really excited to see browsing features in the app. :)

ujjwalagrawal17 commented 6 years ago

Thanks @maskaravivek . Next release is going to be fun with both the GSoC projects ready. Me and mentors discussed about what should we do in remaining time.Then we planned to work on skip feature and #66 .

misaochan commented 6 years ago

Just tested this on master, it works incredibly smoothly, and I love the recent searches feature! Well done @ujjwalagrawal17 . :)