search

commons-app / apps-android-commons

The Wikimedia Commons Android app allows users to upload pictures from their Android phone/tablet to Wikimedia Commons
https://commons-app.github.io/
Apache License 2.0
1.03k stars 1.24k forks source link

Implementation of in-app EXIF modification #1686

Open ilgazer opened 6 years ago

ilgazer commented 6 years ago

Summary:

The app should implement a group of global setting for EXIF modification.

Expected behaviour:

In the settings menu, there should be a setting to remove certain EXIF tags like camera model etc(#70, expansion of #1685 ) This is partially implemented in #1685.

There should be another setting to reduce location accuracy to 20km, 10km etc(#181) by giving slightly wrong coordinates. This could be done by removing decimal places but that would cause many pictures to have the exact same coordinate. Another option would be adding a random number to the coordinate but if a user took enough pictures from his house, averaging all the coordinates would give their location. This would allow the user to choose between different sensitivities of geotagging instead of removing the feature(#1644).

Additionally, a UI to edit EXIF data of a specific image from the ShareActivity could be implemented but I'm not sure how much of the upload workflow would have to be changed for that.

Also, what could be done about making location and timing information available for endangered species through the same feature? (#182)

Screen-shots:

image image image

Would you like to work on the issue?

Yes.

EDIT:I clarified what reducing GPS accuracy is.

nicolas-raoul commented 6 years ago

Endangered species pictures probably are less than 0.01% of all uploaded pictures, so if we implement some location-hiding it should definitely be per-picture rather than a general setting.

However, a hide-location-if-X-meters-from-home feature would have its place in the general settings :-)

What does it mean to "reduce accuracy" for a Commons picture? Could you please include the URL to a Commons picture that has a location with reduced accuracy, so that we can have a look? Thanks! Or is it simply giving slightly wrong coordinates to the picture, for instance by removing decimals?

ilgazer commented 6 years ago

Or is it simply giving slightly wrong coordinates to the picture, for instance by removing decimals?

Yeah, that's what I was thinking. I clarified the OP. Also, I agree that the endangered species thing isn't really a priority, but on #182 people proposed hiding the location if one of the categories you select is an endangered species. That would be seriously hard to implement though, as the upload starts before the category screen.