commons-app / apps-android-commons

The Wikimedia Commons Android app allows users to upload pictures from their Android phone/tablet to Wikimedia Commons
https://commons-app.github.io/
Apache License 2.0
1.01k stars 1.19k forks source link

"This image will be licensed under CCu00A0" #217

Closed nicolas-raoul closed 7 years ago

nicolas-raoul commented 8 years ago

screenshot from 2016-08-03 15-49-44 With Android in Japanese.

whym commented 8 years ago

This apparently is a result of https://translatewiki.net/wiki/Thread:Support/u00A0_only_working_in_en_%28and_not_in_other_languages%29. If we are to restart the localization update, we would need a systematic solution, not just a manual fix of applicable files (in this case a Japanese localization resource file).

According to the declined bug, it looks like the Wikipedia app does not use escaped characters such as "'\u00a0". Similarly we could replace escaped ones into unescaped ones (or in the case of whitespaces, perhaps we can simply use the ASCII space?).

nicolas-raoul commented 8 years ago

Do we really need /u00A0 ? Could we not just use normal spaces instead?

Maybe we could a Groovy Gradle script that fixes such characters as part of the build? No idea how easy/difficult it would be.

We could also switch to a different translation platform like Crowdin.

What do you think?

jayvdb commented 8 years ago

Regarding the general problem of translations not being updated/supported by Translatewiki, I had similar problems with the Wiktionary app. ;-( I would like for TranslateWiki support for these Android apps. Maybe we can hold a chat with their team to find a way forward where everyone wins.

Anyway, I am looking at the localisation webapps, and POEditor appears to be the most friendly to small OSS projects that I could find, with only a 1000 message limit, but otherwise unrestricted. It is also integrated into Github (import and export).

So I tried POEditor in a classroom activity with ~30 participants, with wonderful results for the translation process, but the Github export isn't painless. I have raised a few bugs about it here, but possibly can workaround those by using the POEditor API.

In short, without bug fixes, we would need separate projects for strings.xmland error.xml, and we would loose the XML whitespace at least, and possibly some other oddies I havent fully investigated yet. Also the export to GitHub doesnt include attribution, but that is fairly common with translation tools (except TranslateWiki). One solution is to edit the exported commits before merging, or create a script to export the translations and push them into Github (I intend to attempt this).

I am now going to emulate the same translation process end-to-end using the other two tightly integrated github localisation apps, PhraseApp and LingoHub, and will report back to see if any of them are better with the Github integration.

tobias47n9e commented 8 years ago

I think if we use a translation platform http://zanata.org/ would be a good idea. It has a pretty nice Python interface which automates the retrieving of the translations.

jayvdb commented 8 years ago

Zanata doesnt have Android message support. The list of current formats: http://docs.zanata.org/en/release/user-guide/projects/project-types/

The only pull request for another format is https://github.com/zanata/zanata-server/pull/1261

A task has been very recently created for Android support, and I've voted for it at: https://zanata.atlassian.net/browse/ZNTA-1280

And Github integration is planned with https://zanata.atlassian.net/browse/ZNTA-885

Note that there is also a Zanata in Redhat bugzilla , in case anyone has a support contract with them .. ;-)

nicolas-raoul commented 8 years ago

As a temporary measure we got rid of the special spaces in the English localization file, but they remain in the other languages. Anyone motivated to remove them from there too?

jayvdb commented 8 years ago

I am happy to remove them from the other languages, since I am working in this area. Might be a few days before I do it.

On Wed, Sep 14, 2016 at 10:18 AM, Nicolas Raoul notifications@github.com wrote:

As a temporary measure we got rid of the special spaces in the English localization file, but they remain in the other languages. Anyone motivated to remove them from there too?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/commons-app/apps-android-commons/issues/217#issuecomment-246894676, or mute the thread https://github.com/notifications/unsubscribe-auth/AAA69B1_yBUpkPGWQcjwiPrbPXIzY5Isks5qp2eJgaJpZM4JbW4I .

John Vandenberg

misaochan commented 8 years ago

Thanks @jayvdb !

Halibutt commented 8 years ago

Just dropping by to say I reported the very same problem with the Polish translation by mail a long time ago, glad to see it fixed :)

jayvdb commented 8 years ago

https://github.com/nijel/weblate looks very good, with tight GitHub integration. https://hosted.weblate.org/

nicolas-raoul commented 8 years ago

@jayvdb Could you please copy/paste your comment to #62 ? Thanks :-)