Closed nicolas-raoul closed 4 years ago
@nicolas-raoul Can you confirm if your image has location coordinates in it?
Am adding a fix to prevent it from getting stuck.
both had no lat/long
On Tue, Feb 12, 2019, 14:53 Vivek Maskara <notifications@github.com wrote:
@nicolas-raoul https://github.com/nicolas-raoul Can you confirm if your image has location coordinates in it?
Am adding a fix to prevent it from getting stuck.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/commons-app/apps-android-commons/issues/2439#issuecomment-462626287, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGFBojJucNTSwLQjYUanlSKDNv4M8IPks5vMlbGgaJpZM4a1Uah .
Okay. For images with no lat/lon we show a warning when it comes from nearby. Will fix this immediate issue where the app gets stuck.
Also, as of now even if the user proceeds to upload the image, the wikidata edit is omitted. Am not sure if it is intended to be like this way?
I think the Wikidata edit should be made. Cameras often fail to get the location even if the GPS is enabled. I would not edit the EXIF, but submitting the lat/long in the Commons metadata is an idea indeed.
On Tue, Feb 12, 2019 at 3:48 PM Vivek Maskara notifications@github.com wrote:
Okay. For images with no lat/lon we show a warning when it comes from nearby. Will fix this immediate issue where the app gets stuck.
Also, as of now even if the user proceeds to upload the image, the wikidata edit is omitted. Am not sure if it is intended to be like this way?
- Should I start making the wikidata edit if the user proceeds by clicking on Yes
- As an enhancement should we start adding lat/lon in the EXIF of the image if the location is not there?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/commons-app/apps-android-commons/issues/2439#issuecomment-462638086, or mute the thread https://github.com/notifications/unsubscribe-auth/AAGFBrDL0NjAtdypMaeQ9pX2eWtK-CH-ks5vMmPagaJpZM4a1Uah .
Hmm, I thought the original decision was to display the warning and omit the wikidata edit ONLY if the image has lat/lng coordinates that are far away from the wikidata item's coordinates, not for images with no lat/lng coordinates.
I agree that wikidata edits should be made for the latter, but not for the former. If we haven't yet separated the cases, we have to now.
Definitely don't edit the exif. :)
Thanks for the feedback. Will fix the issue and also check if we differentiate between these two cases or not.
I agree that wikidata edits should be made for the latter, but not for the former. If we haven't yet separated the cases, we have to now.
(still present in 2.10.0.214 obviously as the PR has not been merged yet)
The PR has been merged, but it goes to 2.10-release (because we don't want other enhancements in master to be part of the hotfixes), so it won't be in alpha unfortunately. :/
Yesterday I was able to upload two pictures from Nearby by taking a picture with the app's camera icon. However, using the same Nearby window but instead selecting a pre-made file from gallery produced the same bug that Nicolas has reported above. Not sure if this is the same problem but could be related.
This issue is currently happening for any nearby upload without geolocation. It is possible that the picture you selected from the gallery didn't have any geolocation information. Anyways the fix has already been made and would be available in beta soon. :)
Fix in 2.10.1, coming out very soon. :)
This should be fixed now. Feel free to reopen if the issue still persists.
Steps to reproduce:
Always reproducible, on different nearby items with different pictures (from the same DLSR camera). On the opposite, an upload from the app's built-in gallery did not have this problem (maybe because I took 30 seconds to enter a title and description?).
System logs:
Device and Android version: Android 7.1.2
Commons app version: 2.9.0.209~d86a3aa
Screen-shots: